Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
mda_executeandsingle_districtas scenario parameters. This required refactoring in the schisto.py file as well as all corresponding test, analysis, calibration, and scenario files that required this function._get_age_groups: created this function do define age groups from the parameters. This required refactoring as age groups were initially defined before the parameters were read, and these age groups had been parameterized.Files and File Structure
ASK: Confirm that Emmanuel review is not required for this module as no addt modifications are to be made to these files.
Parameters
Remain hard coded
Local - For Review / Confirmation
delay_till_hsi_a_repeated,delay_till_hsi_b_repeated: Defined these as local because associated with local health seeking behavior. (✅ confirmed OK in chat with Margherita)rr_WASH: Reference meta-analysis here: https://pmc.ncbi.nlm.nih.gov/articles/PMC4256273/Defined to be as local given high location-based elements + high uncertainty described in the study (✅ confirmed OK in chat with Margherita)
Universal - For Review / Confirmation
avg_weight_psac_kg,avg_weight_sac_kg,avg_weight_adult_kg): Defined these as universal parameters because based on WHO avg weights. Uncertain if this is OK, or if they should be marked as undetermined - structural like the structural parameter of age ranges that they correspond to?Undetermined - For Review / Confirmation
main_polling_frequency: currently using it both for the parameter in the initialize_simulation function and within the main SchistoInfectionWormBurdenEvent that it calls. These parameters seem to represent the same polling logic. Is this correct?Assumption
The following variables have been marked as an 'assumption'. I am documenting here for reference for future developers:
heavy_intensity_threshold_PSAC_haematobiumlow_intensity_threshold_haematobiumheavy_intensity_threshold_PSAC_mansonilow_intensity_threshold_mansoniScripts
Future Considerations:@tdm32 to define which schisto related files should remain in master.
As mentioned above, I had to refactor functions when making
mda_executeandsingle_districtscenario parameters. I worked to update the schisto analysis files. in this process, I realized that most were not running in their current state. I updated the files to align with the new refactoring and ensured that these files had the same errors that I was receiving before implementing my changes.I am documenting the error of the files below for reference:
- Schisto_analysis.py
(TypeError: Simulation._configure_logging() got an unexpected keyword argument 'custom_levels ')○ Run_simulation outdated as it has haem and mandoni as parameters
- Baseline_run.py
(TypeError: Demography.__init__() got an unexpected keyword argument 'resourcefilepath')- Schisto_calibration_check (
TypeError: unsupported operand type(s) for /: 'str' and 'str')- Schisto_single_run_local (Runs and generates log files, but ends in following error:)